New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added classmap for autoload #6
Conversation
👍 @ezyang can you merge this pull request ? |
@ezyang can you merge this pull request ? +1 |
@ezyang Can you please merge this pull request? +2 |
Hello, can you please add a Signed-off-by, use your real email address, and get rid of the gratuitous whitespace changes? |
Hello, I added spaces for readability. Should I remove them? |
When making whitespace changes, you should separate them into a non-semantics changing whitespace change, and then a semantics change (with no whitespace changes). Sometimes it's not worth the trouble so you don't change whitespace. But diffs that touch all of the file make people sad. I noticed you have a resubmit: HTML Purifier as a rule only accepts rebased patches on the tip of master, so you should run 'git rebase origin/master' |
I've done. |
Hmm, it doesn't look like you pushed the rebase properly. What commands did you use? |
git clone https://github.com/timoshenko/htmlpurifier.git |
OK, and once you did that, what did you do to the new head? (Also, why are there so many copies of that patch on your copy?) |
What should I do? |
@timoshenko create a new branch from @ezyang master ; add your 2 commits to this branch and create a new pull request... |
I removed duplicated commits using by git rebase -i HEAD~10, @ezyang can you check? |
I merged Rob Loach's version. |
Is it required to declare the constant |
Does #12 resolve the issue for you? |
No description provided.