Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] Clean DirectionalDampedNewtonComputation #27

Merged
merged 8 commits into from Jun 22, 2022
Merged

[ADD] Clean DirectionalDampedNewtonComputation #27

merged 8 commits into from Jun 22, 2022

Conversation

f-dangel
Copy link
Owner

@f-dangel f-dangel commented Jun 21, 2022 •
edited

Adds directionally damped Newton step computation with cleaned up API.

  • Fixes a bug in the eigenvalue criterion in the tests. It always picked one more eigenvalue than specified.

@f-dangel f-dangel changed the title [ADD] DirectionalDampedNewtonComputation [ADD] Cleaned up DirectionalDampedNewtonComputation Jun 21, 2022
@f-dangel f-dangel changed the title [ADD] Cleaned up DirectionalDampedNewtonComputation [ADD] Clean DirectionalDampedNewtonComputation Jun 21, 2022
@coveralls
Copy link

coveralls commented Jun 22, 2022 •
edited

Pull Request Test Coverage Report for Build 2540853228

  • 97 of 112 (86.61%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 80.561%
Changes Missing Coverage Covered Lines Changed/Added Lines %
vivit/optim/directional_damped_newton.py 95 110 86.36%
Totals Coverage Status
Change from base Build 2510383344: 0.7%
Covered Lines: 862
Relevant Lines: 1070
💛 - Coveralls

@f-dangel f-dangel merged commit d871592 into development Jun 22, 2022
@f-dangel f-dangel deleted the directional-damped-newton-api branch June 22, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@f-dangel @coveralls