Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin system to STS for more hackiness #70

Merged
merged 16 commits into from Nov 30, 2021
Merged

Conversation

Zaph-x
Copy link
Member

@Zaph-x Zaph-x commented Nov 24, 2021

This pull request adds a plugin system to STS, such that the user can customise their sts to their liking

Customisation includes:

  • Adding new shorthands
  • Adding new commands
  • Add new functionality

Commits in pr:

  • Added template plugins
  • Added plugin system
  • Updated gitignore

@SEbbaDK
Copy link
Contributor

SEbbaDK commented Nov 25, 2021

Would it be worth having a buy-hook? I have a plugin in mind that would create a custom ware, and then execute something if that ware is attempted bought, but as far as i can see, that isn't possible without hacking around the current system a lot, or am i just missing something?

@Zaph-x
Copy link
Member Author

Zaph-x commented Nov 25, 2021

Would it be worth having a buy-hook? I have a plugin in mind that would create a custom ware, and then execute something if that ware is attempted bought, but as far as i can see, that isn't possible without hacking around the current system a lot, or am i just missing something?

I had this exact thought earlier today, with a pre- and post-sale hook. Definitely worth looking into

Copy link
Member

@falkecarlsen falkecarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is cursed and I pity future FITministers --- let's do it!

main.py Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
Copy link
Member

@falkecarlsen falkecarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Zaph-x Zaph-x merged commit ecc186f into master Nov 30, 2021
@Zaph-x Zaph-x deleted the feature-plugin-system branch April 2, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants