This repository has been archived by the owner on Aug 13, 2022. It is now read-only.
[#102] 카페 메뉴 조회하기 및 삭제하기 #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return ResponseEntity.ok().body(AllMenu); | ||
| } else { | ||
| LOGGER.info("해당 카페의 전체 메뉴를 조회할 수 없습니다. cafeId = {}", cafeId); | ||
| return ResponseEntity.badRequest().build(); |
There was a problem hiding this comment.
실제로 메뉴가 없는경우도 있을수 있는데 400에러를 내리는건 안될것 같습니다.
| @@ -24,4 +34,19 @@ public boolean updateMenu(MenuDTO menuDTO) { | |||
| int updateMenu = menuMapper.updateMenu(menuDTOToMenuConverter.convert(menuDTO)); | |||
| return updateMenu == 1; | |||
| } | |||
|
|
|||
| public List<MenuDTO> getAllMenu(long cafeId) { | |||
| List<MenuDTO> selectAllMenu = menuMapper.selectAllMenu(cafeId); | |||
There was a problem hiding this comment.
cafeId 의 유효성 검증이 필요해보입니다.
(존재하는 카페인지 등의)
| MenuDTO menuDTO = menuService.getMenu(menuId); | ||
| if (menuDTO == null) { | ||
| LOGGER.info("해당 메뉴를 조회할 수 없습니다. cafeId = {}, menuId = {}", cafeId, menuId); | ||
| return ResponseEntity.badRequest().build(); |
There was a problem hiding this comment.
역시 이곳에서도 메뉴가 없다고 해서 400 에러를 내면 안될것 같습니다.
이런경우는 리소스를 찾을수 없는 404에러가 적합합니다.
| return ResponseEntity.ok().body(AllOption); | ||
| } else { | ||
| LOGGER.info("해당 메뉴의 전체 옵션을 조회할 수 없습니다. cafeId = {}, menuId = {}", cafeId, menuId); | ||
| return ResponseEntity.badRequest().build(); |
| } | ||
|
|
||
| public boolean deleteMenu(long menuId) { | ||
| int deleteMenu = menuMapper.deleteMenu(menuId); |
There was a problem hiding this comment.
해당 메뉴가 존재하는지 확인후 없다면 404를 내리고 있는데 삭제를 실패한 경우면 500에러를 내리는게 더 좋을것 같습니다.
| @@ -24,4 +25,19 @@ public boolean updateOption(OptionDTO optionDTO) { | |||
| int updateOption = optionMapper.updateOption(optionDTOToOptionConverter.convert(optionDTO)); | |||
| return updateOption == 1; | |||
| } | |||
|
|
|||
| public List<OptionDTO> getAllOption(long menuId) { | |||
| List<OptionDTO> selectAllOption = optionMapper.selectAllOption(menuId); | |||
There was a problem hiding this comment.
menuId에 대한 검증부터 하는것이 좋을것 같습니다.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102
Fixes #86
Fixes #83
개요
작업사항