Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big update of the whole project to be progress management for Vue #7

Closed
sky-code opened this issue Dec 11, 2017 · 12 comments
Closed

Big update of the whole project to be progress management for Vue #7

sky-code opened this issue Dec 11, 2017 · 12 comments

Comments

@sky-code
Copy link
Collaborator

sky-code commented Dec 11, 2017

I want to add full set of features for tracking progress information (with backward compatibility) just by extending methods with optional parameters about progress.

Because this feature will transform this library from
Complex Loader Management for Vue/Vuex Applications
to Complex Progress Management for Vue/Vuex Applications , propose to rename this project to Vue-progress and change description to
Complex Progress Management for Vue/Vuex Applications
then we can rename this.$loading to this.$progress which is much better in my opinion.

This repo then will redirect to new repo.

This is not necessary but will reflect much better the project purpose

@f
Copy link
Owner

f commented Dec 11, 2017

What kind of progress information you want to track? Like percentage or something?

@f
Copy link
Owner

f commented Dec 11, 2017

If you mean percentage, we may edit the plugin to watch some values.

We may convert this:

state = [
  "fetching data",
  "logging user"
]

into this:

state = {
  "fetching data": 90,
  "logging user": 22
}

@sky-code
Copy link
Collaborator Author

sky-code commented Dec 11, 2017

Yes i am talking about percentage or any other progress value.
In activeLoaders property we can store string or object

{
name: same as loaderMessage atm
progress: value,
max: value
}

and in code handle both activeLoaders types
than state will be

state = [
  {
    name: "fetching data",
    progress: 90,
    max: 100
  },
  "logging user" // no progress info loader
]

but your variant with object instead of list a little bit better, and we can use object instead of number for progress information

state = {
  "fetching data": true, // for no progress information loaders
  "logging user": {
    progress: 90,
    max: 100
    percent: 90 // injected property that calculate percent
  }
}

@jnarowski
Copy link

Would this allow for other messages like errors and whatnot? I love this library but would love to be able to use it to show error information as well, if the request fails.

@f
Copy link
Owner

f commented Jun 6, 2018

Let's plan this for v1.1.0

@f
Copy link
Owner

f commented Jun 8, 2018

Let's plan this for v1.5.0 :)

@sky-code
Copy link
Collaborator Author

sky-code commented Jun 8, 2018

@f publish please the 1.1.4 version to npm

@f
Copy link
Owner

f commented Jun 8, 2018 via email

@f
Copy link
Owner

f commented Jun 8, 2018 via email

@sky-code
Copy link
Collaborator Author

sky-code commented Jun 9, 2018

release 1.1.4 contains bug and require redeploy.
fix f4ca69a

@f
Copy link
Owner

f commented Jun 9, 2018

Deployed with 1.1.5

@f
Copy link
Owner

f commented Jul 2, 2018

@sky-code #44

@f f closed this as completed Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants