Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setCustomAutocompletion does not work with keepCurrentCompleters=true #36

Closed
rappenze opened this issue Aug 16, 2022 · 2 comments
Closed
Labels
bug Something isn't working fixed in live Bug has been fixed and has been uploaded to the directory

Comments

@rappenze
Copy link

Describe the bug
I tried to add more than one custom auto completion category by calling the method several times. But only the last call is transfered to the client side.

To Reproduce
Add the following code:

AceEditor aceEditor = new AceEditor();
aceEditor.setMode(AceMode.sql);
aceEditor.setCustomAutocompletion(Arrays.asList("User", "Role"), "table", true);
aceEditor.setCustomAutocompletion(Arrays.asList("FullName", "Address", "Right"), "column", true);
aceEditor.setAutoComplete(true);

Expected behavior
I expect that auto complete shows all values, but only values with category "column" are shown.

Screenshots

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 3.3.3

Additional context
Vaadin version 23.1.

@F0rce F0rce added bug Something isn't working in progress A issue / feature request that is being worked on labels Aug 16, 2022
@F0rce
Copy link
Owner

F0rce commented Aug 16, 2022

@rappenze thanks for the issue

I was able to reproduce it and found why and where it happens. I'll try to build a hotfix asap.

F0rce added a commit to F0rce/lit-ace that referenced this issue Aug 26, 2022
@F0rce
Copy link
Owner

F0rce commented Aug 26, 2022

Fixed with v3.4.0 (https://vaadin.com/directory/component/ace/3.4.0)

-- Backport to Vaadin 14 soon

@F0rce F0rce closed this as completed Aug 26, 2022
@F0rce F0rce added fixed in live Bug has been fixed and has been uploaded to the directory and removed in progress A issue / feature request that is being worked on labels Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in live Bug has been fixed and has been uploaded to the directory
Projects
None yet
Development

No branches or pull requests

2 participants