Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\Web::request() - Cache requests #299

Open
ursulnegrul opened this issue Apr 13, 2020 · 2 comments
Open

\Web::request() - Cache requests #299

ursulnegrul opened this issue Apr 13, 2020 · 2 comments

Comments

@ursulnegrul
Copy link

Was wondering why the tor list was not cached, would be great if the headers are first checked for ETag or Last Modified.

@ikkez
Copy link
Member

ikkez commented Apr 14, 2020

The web request method uses Last Modified and Cache-Control headers already... that should actually be sufficient.

@ursulnegrul
Copy link
Author

Yes but only if Cache-Control or Max Age headers are present
/Cache-Control:(?:.*)max-age=(\d+)(?:,?.*
for Last Modified or ETag no, you can test for example on https://check.torproject.org/torbulkexitlist
Chrome caches the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants