Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some suggestions #300

Open
soyleung opened this issue May 28, 2020 · 6 comments
Open

Some suggestions #300

soyleung opened this issue May 28, 2020 · 6 comments

Comments

@soyleung
Copy link

Best work will doing this Framework,
i find a good idea form https://github.com/n0nag0n/fatfree-swoole,
yes, it is good.
but this diea is extends on \Base, i dont try it work on Ws, if it work on Ws will Stable. This will be the idea of a milestone.

@KOTRET
Copy link
Contributor

KOTRET commented Jun 3, 2020

Sorry, I don't get the purpose of your suggestion. The code in posted link just strips the hive initialization, which is - of course - faster, but lacks of some features . Also the output obviously is not the same. So what is your issue about?

@ikkez
Copy link
Member

ikkez commented Jun 3, 2020

I guess it's just a reference for a swoole implementation that works and we could keep that in mind for further refactorings

@soyleung
Copy link
Author

soyleung commented Jun 3, 2020

I guess it's just a reference for a swoole implementation that works and we could keep that in mind for further refactorings

yes!!!
good, i try it, and to do something test with it.
I refer to him and modify his structure. Give up the changes he has to make to the core. He does a good job and is quite outstanding.
I will upload my code for reference.

@soyleung
Copy link
Author

soyleung commented Jun 7, 2020

n0nag0n/fatfree-swoole#1 (comment)
Base __Clone class is prohibited, now. I don't know what to think. Now we must be in CLI clone Base, clone should be in CLI, at least let go. This is my idea and suggestion.
I Try to and code: $this-hive['CLI'] after $ref->iscloneable() in recursive class to do together judgement.
God, or what good advice for me? Tks!!!!

@soyleung soyleung reopened this Jun 7, 2020
@soyleung
Copy link
Author

soyleung commented Jun 7, 2020

The code has been updated. Please help me.
https://github.com/soyleung/fatfree-swoole

@n0nag0n
Copy link
Member

n0nag0n commented Jun 8, 2020

@KOTRET @ikkez I know @soyleung tries his (her?) best to communicate in english, but his first language is Chinese. He would be a GREAT asset because swoole docs are more fleshed out in chinese than they are in english.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants