-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--no-render is not correctly taken into account when used with the default configuration #1087
Comments
We are planning a new release early January. We are very close to wrap up the USD plugin which is the last feature we want to add for 2.3 |
noted, thanks for the update! Also if you know which commits I can include for fixing the vtk 9.3 compatibility, that would help unblocking that brew PR. |
We did not merge anything related to VTK 9.3 support. So far I'm unable to reproduce any issue with F3D 2.2.1 with VTK 9.3.0. I wonder if new dependency were added in your VTK 9.3 package that could be detrimental to F3D somehow. Could you provide more info, a stacktrace maybe ? |
Maybe one thing to try for reproduction is run same command after deleting cache directory/file. Alternatively, run in a separate env with a temporary In my experience, the above lead to segfaults with With VTK 9.3.0, I get following stacktrace:
I also tried patching in Kitware/VTK@817df02 since it added a few extra return when there is no render window. This led to another stacktrace:
|
So I've just build VTK 9.3.0, F3D 2.2.1 on my macOS and I'm able to run the following command without any issue:
The stach you are providing points to F3D being used without Please provide more precises steps to reproduce @chenrui333 @cho-m . FYI, I have no idea what " run in a separate env with a temporary HOME (which is how brew's test runs)." means. |
ping @chenrui333 @cho-m ? |
2.3.0 is out, closing. |
@mwestphal sorry about the late reply, trying it now. |
Sorry about the late reply, I can still see some test failure, error log in here, https://github.com/Homebrew/homebrew-core/actions/runs/7773611929/job/21197540326?pr=154232
|
maybe test needs to be updated? |
I think you just found a bug (--no-render + --hdri). |
So after testing and reproducing on my side, a quick fix should be to add
In any case, we have an issue to fix. |
I wish we had fixed this for 2.3.0 though, at least you have a work around for now @chenrui333 |
👋 while trying to rebuild f3d 2.2.1 against vtk 9.3, I ran into some test failure as shown below:
It looks like the vtk 9.3 is supported now, #1068. Any chance of cutting off a new release? Thanks!
relates to Homebrew/homebrew-core#154232
The text was updated successfully, but these errors were encountered: