Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate display to terminal in F3D #1246

Open
mwestphal opened this issue Jan 31, 2024 · 3 comments
Open

Integrate display to terminal in F3D #1246

mwestphal opened this issue Jan 31, 2024 · 3 comments
Labels
type:enhancement New feature or request
Milestone

Comments

@mwestphal
Copy link
Contributor

Context

@snoyer recently added a small feature in the libf3d to transfrom an image into displayable terminal (#1219 ) and created a python app for it: https://github.com/snoyer/f3d/blob/ef9d6c0c64909712ed10e840229890dcd0bb1255/examples/libf3d/python/render-terminal/render_terminal_mouse.py

Let's discuss how to cleanly integrate that in F3D

@snoyer
Copy link
Contributor

snoyer commented Jan 31, 2024

a python app for it

that's a generous way to phrase it, I would have called it a "janky POC" myself :)

There was a quick mention of making terminal output a type of window and then just plugging it into the existing F3D app; while we could probably forward keyboard and mouse events the limited resolution of the output mean it couldn't properly support all of the features of the app (unreadable text actors for example).

Should it be looked at more like the android version, ie. as a custom, platform-specific front-end?
Maybe it depends on how much you expect out of it compared to the actual F3D?

@mwestphal
Copy link
Contributor Author

mwestphal commented Jan 31, 2024

I think it has value to be integrated in the F3D executable, even if there is limitations.

Alternatively, it could be a separate executable or pure python app, but it would not help with integration into distribution packages and such, especially if in its own repository.

@Meakk
Copy link
Contributor

Meakk commented Feb 2, 2024

Another idea for the short term: Have a collection of python tools in the repository. You can see that as ready-to-use and useful examples.
We can make it part of the installation process and package it in the wheels.
I think it's be still useful to have this feature in the F3D application itself too tho

@mwestphal mwestphal added this to the 2.4.0 milestone Feb 4, 2024
@mwestphal mwestphal added the type:enhancement New feature or request label Feb 9, 2024
@mwestphal mwestphal modified the milestones: 2.4.0, 2.5.0 Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
Status: Investigate
Development

No branches or pull requests

3 participants