Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blur shader is too slow #26

Closed
mwestphal opened this issue Nov 12, 2021 · 3 comments · Fixed by #630
Closed

Blur shader is too slow #26

mwestphal opened this issue Nov 12, 2021 · 3 comments · Fixed by #630
Assignees
@Meakk
Labels
type:enhancement New feature or request
Milestone
2.0.0

Comments

@mwestphal
Copy link
Contributor

Improve bokeh blur shader performance.

This approach looks promising: https://www.shadertoy.com/view/Xd33Ds
@mwestphal
Copy link
Contributor Author

more info here: https://gitlab.kitware.com/f3d/f3d/-/issues/194

@mwestphal mwestphal added type:enhancement New feature or request Priority:P1 labels Nov 12, 2021
@mwestphal mwestphal added this to the 1.3.0 milestone Nov 12, 2021
@mwestphal mwestphal modified the milestones: 1.3.0, 2.0.0 Aug 14, 2022
@mwestphal
Copy link
Contributor Author

Is this still needed @Meakk ? With the cache it is not as critical, wdyt ?

@Meakk
Copy link
Contributor

Meakk commented Feb 1, 2023

The blur shader is not cached. When enabling blur with a low-end GPU, fps drops dramatically. It's not critical but keep the issue opened.

@Meakk Meakk self-assigned this Feb 7, 2023
@Meakk Meakk mentioned this issue Feb 15, 2023
Merged
@Meakk Meakk closed this as completed in #630 Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Meakk Meakk

Labels
type:enhancement New feature or request
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Implements hexagonal Bokeh blur Meakk/f3d
2 participants
@mwestphal @Meakk