Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi! I cleaned up your code for you! #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions README.rst
Expand Up @@ -49,7 +49,7 @@ These permissions break down into three methods so that you can give groups, ind

Git Repo Polling (complete):

DjTracker can polling a git repo's commits, and auto-update issues based on a certain string. This is pretty common in other issue trackers as well. You can set this up by setting the "Git Repo Path" of a project, which correlates to a location on your *filesystem*. gitpython doesn't handle parsing git URLs as far as I can tell yet, so you need to have the repo checked out on the server. This has a couple of drawbacks, such as you'll need to setup a cron to pull down commits to that repo on a semi-regular basis.
DjTracker can polling a git repo's commits, and auto-update issues based on a certain string. This is pretty common in other issue trackers as well. You can set this up by setting the "Git Repo Path" of a project, which correlates to a location on your *filesystem*. gitpython doesn't handle parsing git URLs as far as I can tell yet, so you need to have the repo checked out on the server. This has a couple of drawbacks, such as you'll need to setup a cron to pull down commits to that repo on a semi-regular basis.

You'll also need to initialize the project by giving it a starting commit hash as well. This allows the git poller to have a starting location in the git log to parse from. It'll then be able to parse from that commit forward. Again, some drawbacks, it'll brute force the list of commits, meaning that it can find commits in other branches than the master. Again, this appears to me as another limit of the 'gitpython' package. (Note: I don't mean any ill towards gitpython, I love the package, and I'm sure it'll continue its improvement.)

Expand All @@ -75,12 +75,12 @@ Issues are attached to projects via foreign keys. You can comment on issues, cha
User Profiles (80% complete):
------------------------------------------------

Currently I don't see an excessively large need for these, but that could change depending on use cases. As a result I went ahead and built a user profile module just in case. It's currently very limited, but you can view your profile (and the profile of others) to see what issues they have assigned to them.
Currently I don't see an excessively large need for these, but that could change depending on use cases. As a result I went ahead and built a user profile module just in case. It's currently very limited, but you can view your profile (and the profile of others) to see what issues they have assigned to them.

Email Handling
------------------------------------------------

DjTracker has the ability to parse email addresses for new comments and new issues. Currently this only supports IMAP, but POP3 support is planned for the future.
DjTracker has the ability to parse email addresses for new comments and new issues. Currently this only supports IMAP, but POP3 support is planned for the future.

Email Settings
------------------------------------------------
Expand All @@ -99,12 +99,12 @@ Expected Email Subjects
DjTracker needs email subjects to be formed in a certain fashion in order to properly create issues on your behalf. If you're creating a new issue via email, the following subject is expected:

DjTracker: [project-slug]: Your Title

If you're responding on an issue, you'd use the following:

DjTracker: [project-slug]: Issue #5
That'll add the comment onto the end of the current issue with an ID of 5.

That'll add the comment onto the end of the current issue with an ID of 5.

Email Cron Job
------------------------------------------------
Expand Down
234 changes: 117 additions & 117 deletions djtracker/fixtures/initial_data.json
@@ -1,188 +1,188 @@
[
{
"pk": 1,
"model": "djtracker.project",
"fields": {
"allow_anon_comment": false,
"modified_date": "2009-11-14 16:50:17",
"allow_authed_editing": true,
"groups_can_comment": [],
"description": "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Suspendisse in diam est. In id tortor vitae nulla iaculis imperdiet. Quisque scelerisque ipsum suscipit nibh scelerisque gravida. In sit amet dolor lectus. Vestibulum sit amet consectetur urna. Nam sit amet ligula ac turpis consequat dapibus sed et leo. Donec eget quam massa. Sed ac porta ante. In mi metus, rhoncus quis viverra in, vulputate eu erat. Aenean facilisis mauris nec lacus congue tempor. Vivamus facilisis, augue at imperdiet interdum, velit urna consequat nisi, sed tempus erat felis sed turpis. Suspendisse bibendum leo vel metus ultrices congue. In fringilla purus varius velit rutrum eget faucibus turpis blandit. Cras mauris metus, cursus et hendrerit id, rutrum at purus. Vestibulum accumsan tincidunt ante sed pretium. Phasellus nec mattis lacus.",
"groups_can_edit": [],
"users_can_comment": [],
"allow_authed_viewing": true,
"groups_can_view": [],
"name": "Default Project",
"users_can_edit": [],
"allow_authed_comment": true,
"users_can_view": [],
"created_date": "2009-11-14 16:50:17",
"active": true,
"allow_anon_viewing": true,
"slug": "default-project",
"pk": 1,
"model": "djtracker.project",
"fields": {
"allow_anon_comment": false,
"modified_date": "2009-11-14 16:50:17",
"allow_authed_editing": true,
"groups_can_comment": [],
"description": "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Suspendisse in diam est. In id tortor vitae nulla iaculis imperdiet. Quisque scelerisque ipsum suscipit nibh scelerisque gravida. In sit amet dolor lectus. Vestibulum sit amet consectetur urna. Nam sit amet ligula ac turpis consequat dapibus sed et leo. Donec eget quam massa. Sed ac porta ante. In mi metus, rhoncus quis viverra in, vulputate eu erat. Aenean facilisis mauris nec lacus congue tempor. Vivamus facilisis, augue at imperdiet interdum, velit urna consequat nisi, sed tempus erat felis sed turpis. Suspendisse bibendum leo vel metus ultrices congue. In fringilla purus varius velit rutrum eget faucibus turpis blandit. Cras mauris metus, cursus et hendrerit id, rutrum at purus. Vestibulum accumsan tincidunt ante sed pretium. Phasellus nec mattis lacus.",
"groups_can_edit": [],
"users_can_comment": [],
"allow_authed_viewing": true,
"groups_can_view": [],
"name": "Default Project",
"users_can_edit": [],
"allow_authed_comment": true,
"users_can_view": [],
"created_date": "2009-11-14 16:50:17",
"active": true,
"allow_anon_viewing": true,
"slug": "default-project",
"allow_anon_editing": false
}
},
},
{
"pk": 1,
"model": "djtracker.milestone",
"pk": 1,
"model": "djtracker.milestone",
"fields": {
"modified_date": "2009-11-14 16:52:10",
"description": "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Suspendisse in diam est. In id tortor vitae nulla iaculis imperdiet. Quisque scelerisque ipsum suscipit nibh scelerisque gravida. In sit amet dolor lectus. Vestibulum sit amet consectetur urna. Nam sit amet ligula ac turpis consequat dapibus sed et leo. Donec eget quam massa. Sed ac porta ante. In mi metus, rhoncus quis viverra in, vulputate eu erat. Aenean facilisis mauris nec lacus congue tempor. Vivamus facilisis, augue at imperdiet interdum, velit urna consequat nisi, sed tempus erat felis sed turpis. Suspendisse bibendum leo vel metus ultrices congue. In fringilla purus varius velit rutrum eget faucibus turpis blandit. Cras mauris metus, cursus et hendrerit id, rutrum at purus. Vestibulum accumsan tincidunt ante sed pretium. Phasellus nec mattis lacus.",
"project": 1,
"created_date": "2009-11-14 16:52:10",
"active": true,
"goal_date": "2009-11-24 16:52:08",
"slug": "default-milestone",
"modified_date": "2009-11-14 16:52:10",
"description": "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Suspendisse in diam est. In id tortor vitae nulla iaculis imperdiet. Quisque scelerisque ipsum suscipit nibh scelerisque gravida. In sit amet dolor lectus. Vestibulum sit amet consectetur urna. Nam sit amet ligula ac turpis consequat dapibus sed et leo. Donec eget quam massa. Sed ac porta ante. In mi metus, rhoncus quis viverra in, vulputate eu erat. Aenean facilisis mauris nec lacus congue tempor. Vivamus facilisis, augue at imperdiet interdum, velit urna consequat nisi, sed tempus erat felis sed turpis. Suspendisse bibendum leo vel metus ultrices congue. In fringilla purus varius velit rutrum eget faucibus turpis blandit. Cras mauris metus, cursus et hendrerit id, rutrum at purus. Vestibulum accumsan tincidunt ante sed pretium. Phasellus nec mattis lacus.",
"project": 1,
"created_date": "2009-11-14 16:52:10",
"active": true,
"goal_date": "2009-11-24 16:52:08",
"slug": "default-milestone",
"name": "Default Milestone"
}
},
},
{
"pk": 1,
"model": "djtracker.component",
"pk": 1,
"model": "djtracker.component",
"fields": {
"modified_date": "2009-11-14 16:52:19",
"name": "Default Component",
"project": 1,
"created_date": "2009-11-14 16:52:19",
"active": true,
"modified_date": "2009-11-14 16:52:19",
"name": "Default Component",
"project": 1,
"created_date": "2009-11-14 16:52:19",
"active": true,
"slug": "default-component"
}
},
},
{
"pk": 1,
"model": "djtracker.version",
"pk": 1,
"model": "djtracker.version",
"fields": {
"modified_date": "2009-11-14 16:52:41",
"name": "Default Version",
"project": 1,
"created_date": "2009-11-14 16:52:41",
"active": true,
"modified_date": "2009-11-14 16:52:41",
"name": "Default Version",
"project": 1,
"created_date": "2009-11-14 16:52:41",
"active": true,
"slug": "default-version"
}
},
},
{
"pk": 1,
"model": "djtracker.status",
"pk": 1,
"model": "djtracker.status",
"fields": {
"name": "Open",
"name": "Open",
"slug": "open"
}
},
},
{
"pk": 2,
"model": "djtracker.status",
"pk": 2,
"model": "djtracker.status",
"fields": {
"name": "Closed",
"name": "Closed",
"slug": "closed"
}
},
},
{
"pk": 3,
"model": "djtracker.status",
"pk": 3,
"model": "djtracker.status",
"fields": {
"name": "Deferred",
"name": "Deferred",
"slug": "deferred"
}
},
},
{
"pk": 4,
"model": "djtracker.status",
"pk": 4,
"model": "djtracker.status",
"fields": {
"name": "Denied",
"name": "Denied",
"slug": "denied"
}
},
},
{
"pk": 1,
"model": "djtracker.priority",
"pk": 1,
"model": "djtracker.priority",
"fields": {
"name": "Urgent",
"name": "Urgent",
"slug": "urgent"
}
},
},
{
"pk": 2,
"model": "djtracker.priority",
"pk": 2,
"model": "djtracker.priority",
"fields": {
"name": "Critical",
"name": "Critical",
"slug": "critical"
}
},
},
{
"pk": 3,
"model": "djtracker.priority",
"pk": 3,
"model": "djtracker.priority",
"fields": {
"name": "Trivial",
"name": "Trivial",
"slug": "trivial"
}
},
},
{
"pk": 4,
"model": "djtracker.priority",
"pk": 4,
"model": "djtracker.priority",
"fields": {
"name": "Normal",
"name": "Normal",
"slug": "normal"
}
},
},
{
"pk": 5,
"model": "djtracker.priority",
"pk": 5,
"model": "djtracker.priority",
"fields": {
"name": "Low",
"name": "Low",
"slug": "low"
}
},
},
{
"pk": 6,
"model": "djtracker.priority",
"pk": 6,
"model": "djtracker.priority",
"fields": {
"name": "High",
"name": "High",
"slug": "high"
}
},
},
{
"pk": 1,
"model": "djtracker.issuetype",
"pk": 1,
"model": "djtracker.issuetype",
"fields": {
"name": "Bug",
"name": "Bug",
"slug": "bug"
}
},
},
{
"pk": 2,
"model": "djtracker.issuetype",
"pk": 2,
"model": "djtracker.issuetype",
"fields": {
"name": "Defect",
"name": "Defect",
"slug": "defect"
}
},
},
{
"pk": 3,
"model": "djtracker.issuetype",
"pk": 3,
"model": "djtracker.issuetype",
"fields": {
"name": "Feature Request",
"name": "Feature Request",
"slug": "feature-request"
}
},
{
"pk": 1,
"model": "djtracker.issue",
"fields": {
"status": 1,
"priority": 2,
"name": "Test Issue",
"created_date": "2009-11-14 16:52:57",
"modified_date": "2009-11-14 16:52:57",
"assigned_to": null,
"component": 1,
"created_by": null,
"project": 1,
"version": 1,
"watched_by": [],
"issue_type": 1,
"milestone": 1,
"active": true,
},
{
"pk": 1,
"model": "djtracker.issue",
"fields": {
"status": 1,
"priority": 2,
"name": "Test Issue",
"created_date": "2009-11-14 16:52:57",
"modified_date": "2009-11-14 16:52:57",
"assigned_to": null,
"component": 1,
"created_by": null,
"project": 1,
"version": 1,
"watched_by": [],
"issue_type": 1,
"milestone": 1,
"active": true,
"description": "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Suspendisse in diam est. In id tortor vitae nulla iaculis imperdiet. Quisque scelerisque ipsum suscipit nibh scelerisque gravida. In sit amet dolor lectus. Vestibulum sit amet consectetur urna. Nam sit amet ligula ac turpis consequat dapibus sed et leo. Donec eget quam massa. Sed ac porta ante. In mi metus, rhoncus quis viverra in, vulputate eu erat. Aenean facilisis mauris nec lacus congue tempor. Vivamus facilisis, augue at imperdiet interdum, velit urna consequat nisi, sed tempus erat felis sed turpis. Suspendisse bibendum leo vel metus ultrices congue. In fringilla purus varius velit rutrum eget faucibus turpis blandit. Cras mauris metus, cursus et hendrerit id, rutrum at purus. Vestibulum accumsan tincidunt ante sed pretium. Phasellus nec mattis lacus."
}
}
Expand Down
4 changes: 2 additions & 2 deletions djtracker/fixtures/testdata/00_test_users.json
@@ -1,4 +1,4 @@
[ { "fields" :
[ { "fields" :
{ "date_joined" : "2009-12-08 03:56:19",
"email" : "admin@djtracker.corp",
"first_name" : "",
Expand All @@ -15,7 +15,7 @@
"model" : "auth.user",
"pk" : 1
},
{ "fields" :
{ "fields" :
{ "date_joined" : "2009-12-13 20:26:17",
"email" : "creator@djtracker.corp",
"first_name" : "",
Expand Down