Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in docs and improvement for vue example in docs. #357

Closed
ByMykel opened this issue Mar 22, 2024 · 2 comments · Fixed by #358
Closed

Typo in docs and improvement for vue example in docs. #357

ByMykel opened this issue Mar 22, 2024 · 2 comments · Fixed by #358

Comments

@ByMykel
Copy link

ByMykel commented Mar 22, 2024

Hi.

I have noticed that you have an extra greater-than sign (>) in every vue example code:

image

return `<script setup lang="ts">>\n${lines.join('\n')}\n</script>\n\n<template>\n${html}\n</template>`

When I was trying to add a tooltip to my chart, I couldn't find where you got StackedBar.selectors.bar from until I found on another page that you import that from @unovis/ts.

Maybe it would be great to add that to the example code?

image

BTW, I wanted to open a PR but CLA was to much for a small type. So my question is, do I need to sign that to remove a character from the docs?

@rokotyan
Copy link
Contributor

Thanks for pointing this out @ByMykel! Unfortunately the CLA is needed to accept any outside contributions. It's a weird corporate thing we can do nothing about 😔

@zernonia Since you are the creator of the Vue integration, what do you think about re-exporting selectors along with the Vue components? We started doing it in React recently for convenience, e.g.export const VisAreaSelectors = Area.selectors

@zernonia
Copy link
Contributor

Hey @rokotyan . Yeah sure, no prob! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants