Feature Request: Configurable Min Height Setting for Stacked Bars

[seancrater]

Currently, a user can input that they want a min height of 1px via props for the StackedBars component but what if they want it to be 3px or 5px? What if they've applied a stroke to the bars?

Currently I'm facing the pain point of having a stroke making it so the min1Px prop effectively does nothing, you don't see the color of my bar due to the stroke. I'd love to have some control over that and I've tried applying some CSS hacks to the bar paths but unfortunately that won't work either due to the positioning of the bars calculated by the library.

Love the mission of this library, just wanted to raise this as a pain point 😄

[rokotyan]

Thanks for the feedback @seancrater! We thought about this and intentionally made it only 1px for the StackedBar component because a larger value can distort the visual encoding of the chart. But we didn't think about the 'stroke' use case. Maybe we should revisit it and just warn users instead of enforcing it.

And we welcome code contributions, if you want to have this feature sooner you can try playing with this line in the code, and raising a PR:

unovis/packages/ts/src/components/stacked-bar/index.ts

Line 209 in d0179dc

const h = !isEntering && config.barMinHeight1Px && (height < 1) && isFinite(value) && (value !== config.barMinHeightZeroValue) ? 1 : height