Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting an error about missing variable #124

Closed
sewalshmsft opened this issue Dec 8, 2020 · 3 comments
Closed

Getting an error about missing variable #124

sewalshmsft opened this issue Dec 8, 2020 · 3 comments
Assignees
Labels

Comments

@sewalshmsft
Copy link

sewalshmsft commented Dec 8, 2020

Should this line use bigip_regkey instead of license for the variable declaration that is getting passed to the DO?

license = var.licenses["license3"] != "" ? var.licenses["license3"] : ""

The DO requires ${bigip_regKey} as an input for the variable, not ${license}.

https://github.com/Mikej81/f5-bigip-hardening-DO/blob/5f3563afabf730e3851a83734fdf18cb689b9c1c/dist/terraform/latest/byol_cluster_waf_tier.json#L12

@Mikej81 Mikej81 self-assigned this Dec 8, 2020
@Mikej81 Mikej81 added the bug label Dec 8, 2020
@Mikej81
Copy link
Collaborator

Mikej81 commented Dec 8, 2020

Patched in DO Repo. Mikej81/f5-bigip-hardening-DO@5ae8236

@Mikej81 Mikej81 closed this as completed Dec 8, 2020
@sewalshmsft
Copy link
Author

sewalshmsft commented Dec 8, 2020

These two lines in the firewall/bigip.tf use bigip_regkey, these will need updating too:

bigip_regKey = var.licenses["license1"] != "" ? var.licenses["license1"] : ""

bigip_regKey = var.licenses["license2"] != "" ? var.licenses["license2"] : ""

@Mikej81
Copy link
Collaborator

Mikej81 commented Dec 8, 2020

patched in commit commit 4f2373c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants