Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 Support #34

Closed
MatthewWEdwards opened this issue Jul 20, 2019 · 5 comments
Closed

Python 3 Support #34

MatthewWEdwards opened this issue Jul 20, 2019 · 5 comments
Labels
improvement Improvement of existing features

Comments

@MatthewWEdwards
Copy link

MatthewWEdwards commented Jul 20, 2019

Hi,

I am planning on using this code in a personal Python 3 project. Are the maintainers of this repository interested in a Python 3 rewrite? Does the current implementation support Python 3? (I have not dug into the code deeply, so I am uncertain if this package is compatible with Python 3.) If work is needed to support Python 3, I'd be happy to contribute

@f90
Copy link
Owner

f90 commented Jul 22, 2019

I just updated to Python 3.6.8 using the 2to3 library, can you try to work with the new code a bit and see if there are any errors? Thank you!

@MatthewWEdwards
Copy link
Author

Will do, thank you for the quick response

@f90
Copy link
Owner

f90 commented Jul 29, 2019

@MatthewWEdwards Is everything running normally? Then I can close this issue?

@f90 f90 added the improvement Improvement of existing features label Jul 29, 2019
@MatthewWEdwards
Copy link
Author

Inference appears to work. I haven't had the chance to experiment with training. I think it is alright to close the issue, and I will open a new one if I encounter any issues.

Thanks for the software and help!

@f90
Copy link
Owner

f90 commented Jul 30, 2019

OK cool, i think you can reopen this issue in case you run into Python 3-specific trouble in the future, instead of having to open a new one.
Thanks!

@f90 f90 closed this as completed Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement of existing features
Projects
None yet
Development

No branches or pull requests

2 participants