Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Options correction, Clone Implementation on public structs #51

Merged
merged 2 commits into from
Dec 20, 2020
Merged

Graph Options correction, Clone Implementation on public structs #51

merged 2 commits into from
Dec 20, 2020

Conversation

ManevilleF
Copy link
Contributor

No description provided.

@ManevilleF ManevilleF changed the title public database structs and enums implement Clone Graph Options correction, Clone Implementation on public structs Dec 8, 2020
Copy link
Contributor Author

@ManevilleF ManevilleF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fMeow So a small PR fixing a few Graph options, adding Clone to public structs and fixes requested by the CI

- [X] Graph Management
- [X] Index Management
- [ ] User Management
- (X) Graph Management
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a weird reason the CI failed on this, considering it as links

//! the retrieval of existing indexes, as ArangoDB creates a primary index on
//! every collection.
//! For detailed information about ArangoDB indexes, please check out the
//! official ArangoDB [documentation](https://www.arangodb.com/docs/stable/http/indexes.html).
//!
//! [Primary]: https://www.arangodb.com/docs/stable/http/indexes.html#primary-index
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI was failing on this too, a missing link

assert_eq!(result.orphan_collections.len(), 1);
// Would work only with Enterprise Edition
//
// assert_eq!(result.is_disjoint.unwrap(), false);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really test this. I don't have enteprise edition and ArangoDB doesn't respond with the optional fields

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I signaled the issue to the arangoDB team and agree that it should respond, so maybe in the future it will work

@ManevilleF
Copy link
Contributor Author

Can someone review this? @fMeow or @inzanez, I finished my migration/schema generation system for ArangoDB (aragog and aragog_cli) But the graph part won't work perfectly until this is deployed.
Also, the cloning would be helpful

@fMeow fMeow merged commit a669281 into fMeow:master Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants