Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reqwest + rustls #57

Closed
theduke opened this issue Jan 4, 2021 · 6 comments
Closed

reqwest + rustls #57

theduke opened this issue Jan 4, 2021 · 6 comments

Comments

@theduke
Copy link
Contributor

theduke commented Jan 4, 2021

reqwest has the rustls-tls feature that will use rustls instead of the native system openssl library.

Would be great to have an extra feature to toggle this.

@theduke theduke changed the title reqwuest + rustls reqwwest + rustls Jan 4, 2021
@theduke theduke changed the title reqwwest + rustls reqwest + rustls Jan 4, 2021
@ManevilleF
Copy link
Contributor

I think you can enable this in your project without arangors changing anything: This Pull request

@theduke
Copy link
Contributor Author

theduke commented Jan 13, 2021

No, that doesn't work, as explained in the PR.

@fMeow
Copy link
Owner

fMeow commented Mar 28, 2021

Sorry for the long delay.

I found a solution, see example for detail.

Maybe I can extract arangors::Client related codes into another crate, and offer reqwest with openssl and rustls in that crate.

@theduke
Copy link
Contributor Author

theduke commented Mar 29, 2021

I'm working on a generic http client not tied to any specific backend, which allows libraries like this to write against an independent client, and for the end user to pick the actual client via a separate crate.

If you're interested, I can ping you once I publish it.

@fMeow
Copy link
Owner

fMeow commented Mar 29, 2021

Thank you so much! @theduke

I actually has already publish one with some minor modification on the arangors::client mod.

@fMeow
Copy link
Owner

fMeow commented May 1, 2021

With the v0.5.0, I have added two feature gate to enable rustls in reqwest.

I think this issue can be closed.

Thank you so much for your feedback!

@theduke theduke closed this as completed May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants