Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maybe-async breaks crates #21

Open
xfbs opened this issue Aug 23, 2023 · 0 comments
Open

maybe-async breaks crates #21

xfbs opened this issue Aug 23, 2023 · 0 comments

Comments

@xfbs
Copy link

xfbs commented Aug 23, 2023

Hey!

I just noticed something that seems kind of bad! The is_sync feature of maybe-async breaks stuff. Here's an example:

Create a new, empty crate, add these dependencies:

crates-index = { version = "2.1.1", features = ["git", "git-https"] }
rust-s3 = "0.33.0"

Building this will break hard. Disabling either one of the dependencies makes the build work.

Why? Both of these crates us maybe-async. The crates-index crate enables the is_sync feature. The presence of this feature breaks rust-s3.

My understanding is that this feature is not "additive".

Can someone look into this? In my project, I am able to work around this, but this issue currently makes doing cargo build on the workspace level broken. In my workspace I can work around it by always compiling crates individually. But maybe it would be a good idea to peek into this and see if there was some way to solve this.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant