[build] separate memcheck and helgrind suppressions files

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
kronosnet · Aug 17, 2016 · ff80c90 · ff80c90
1 parent fc928ac
commit ff80c90
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 3 deletions.
diff --git a/build-aux/check.mk b/build-aux/check.mk
@@ -1,7 +1,7 @@
-VALGRIND = valgrind -q --error-exitcode=127 --suppressions=$(abs_top_srcdir)/build-aux/knet_valgrind.supp
+VALGRIND = valgrind -q --error-exitcode=127
 
-MEMCHECK = $(VALGRIND) --track-fds=yes --leak-check=full
-HELGRIND = $(VALGRIND) --tool=helgrind
+MEMCHECK = $(VALGRIND) --track-fds=yes --leak-check=full --suppressions=$(abs_top_srcdir)/build-aux/knet_valgrind_memcheck.supp
+HELGRIND = $(VALGRIND) --tool=helgrind --suppressions=$(abs_top_srcdir)/build-aux/knet_valgrind_helgrind.supp
 
 check-memcheck: $(check_PROGRAMS)
 	$(MAKE) check LOG_COMPILE="libtool --mode=execute $(MEMCHECK)"

diff --git a/build-aux/knet_valgrind_helgrind.supp b/build-aux/knet_valgrind_helgrind.supp
@@ -0,0 +1,25 @@
+{
+   link enable/disable known race (safe to ignore)
+   Helgrind:Race
+   fun:_link_updown
+   fun:knet_link_set_enable
+   fun:test
+   fun:main
+}
+{
+   link enable/disable known race (safe to ignore)
+   Helgrind:Race
+   fun:_handle_heartbt_thread
+   obj:/usr/lib64/valgrind/vgpreload_helgrind-amd64-linux.so
+   fun:start_thread
+   fun:clone
+}
+{
+   helgrind glitch in parsing the heartbeat code
+   Helgrind:Race
+   fun:_handle_check_each
+   fun:_handle_heartbt_thread
+   obj:/usr/lib64/valgrind/vgpreload_helgrind-amd64-linux.so
+   fun:start_thread
+   fun:clone
+}
diff --git a/build-aux/knet_valgrind_memcheck.supp b/build-aux/knet_valgrind_memcheck.supp