Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timestamp regex doesn't support timezone other than Zulu #500

Closed
brandonpittman opened this issue Apr 2, 2024 · 1 comment
Closed

Timestamp regex doesn't support timezone other than Zulu #500

brandonpittman opened this issue Apr 2, 2024 · 1 comment
Assignees
@fabian-hiller
Labels
duplicate This issue or pull request already exists

Comments

@brandonpittman
Copy link
Contributor

brandonpittman commented Apr 2, 2024 •
edited
Loading

valibot/library/src/regex.ts

Lines 81 to 82 in 6ca70b2

export const ISO_TIMESTAMP_REGEX =
/^\d{4}-(?:0[1-9]|1[0-2])-(?:[12]\d|0[1-9]|3[01])T(?:0\d|1\d|2[0-3])(?::[0-5]\d){2}(?:\.\d{1,9})?Z$/u;

Should support a time like 2024-04-02T08:52:31+07:00.
@brandonpittman brandonpittman mentioned this issue Apr 2, 2024
Closed
@fabian-hiller
Copy link
Owner

Thank you! This seems related to #495.

@fabian-hiller fabian-hiller self-assigned this Apr 2, 2024
@fabian-hiller fabian-hiller added the duplicate This issue or pull request already exists label Apr 2, 2024
@brandonpittman brandonpittman closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabian-hiller fabian-hiller

Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix isoTimestamp regex brandonpittman/valibot
2 participants
@brandonpittman @fabian-hiller