We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi! Current implementation of branded types uses single symbol for single branded type, that results to never type in tests
valibot/library/src/methods/brand/brand.test.ts
Lines 32 to 38 in ce49b0b
It happends because typescript resolves { [symbol]: "1"} & { [symbol]: "2" } to never.
{ [symbol]: "1"} & { [symbol]: "2" }
never
I'll make a pr for fix, that replaces single value to object of values
The text was updated successfully, but these errors were encountered:
Thank you! Can you also add a test that checks this?
Sorry, something went wrong.
@fabian-hiller sure!
fabian-hiller
Successfully merging a pull request may close this issue.
Hi! Current implementation of branded types uses single symbol for single branded type, that results to never type in tests
valibot/library/src/methods/brand/brand.test.ts
Lines 32 to 38 in ce49b0b
It happends because typescript resolves
{ [symbol]: "1"} & { [symbol]: "2" }
tonever
.I'll make a pr for fix, that replaces single value to object of values
The text was updated successfully, but these errors were encountered: