Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential crash with looping FLAC music #1132

Closed
XxMiltenXx opened this issue Jan 1, 2024 · 1 comment
Closed

Potential crash with looping FLAC music #1132

XxMiltenXx opened this issue Jan 1, 2024 · 1 comment

Comments

@XxMiltenXx
Copy link

Background

Version of Crispy Doom: 6.0 (both x32 and x64)

Operating System and version: Windows 11 x64

Game: Doom

Music Packs

Bug description

Observed behavior:

Depending on the loop tags in a song, the music will crash upon trying to loop. In the d_runnin.flac (see Working [FLAC]), if the LOOP_START is set to 330750 and the LOOP_END is set to 7938000 (as is intended for this song), the song will loop just fine without crashing.
However, if I change the LOOP_END to 400000 (see Not Working [FLAC], it will crash upon trying to loop.
d_stalks will even crash with the intended loop points (LOOP_START 153391, LOOP_END 8129737).

If the files are OGG, they work just fine, regardless of how the LOOP_END is set. GZDoom also plays the FLAC files just fine.
I even tested if the FLACs itself are faulty and converted them from WAV with different programs (ffmpeg, Audacity) and compression levels (0, 5, 8), but the result is the same.

Files:

Not working [FLAC]: https://sc-d70.retrohost.net/test/nw/d_runnin.flac
Not working [FLAC]: https://sc-d70.retrohost.net/test/nw/d_stalks.flac
Working [FLAC]: https://sc-d70.retrohost.net/test/w/d_runnin.flac
Working [OGG]: https://sc-d70.retrohost.net/test/w/d_runnin.ogg
Working [OGG]: https://sc-d70.retrohost.net/test/w/d_stalks.ogg

Additional Info

The isn't any error message, the game just freezes for a second, then shuts down.

@mikeday0
Copy link
Collaborator

mikeday0 commented Jan 1, 2024

Sorry for the trouble. This is a well-known issue with SDL Mixer. It has been fixed by that team some time ago but there hasn't been a new SDL Mixer release as of yet. (Supposed to be soon.) In the meantime, please use OGG as a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants