Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stub functions? #36

Open
malespiaut opened this issue Jul 21, 2023 · 4 comments
Open

Remove stub functions? #36

malespiaut opened this issue Jul 21, 2023 · 4 comments

Comments

@malespiaut
Copy link
Contributor

Hello,

I wanted to start fixing all -Wextra warnings, but some of them are about unused function parameters, because the functions are stubbed.

Is it necessary to keep some functions like UL_ChangeDrive() (in rt_util.c)?

@fabiangreffrath
Copy link
Owner

We should get rid of as many distractions and indirections as possible.

@malespiaut
Copy link
Contributor Author

On my way to clean the code up, once again!

@fabiangreffrath
Copy link
Owner

fabiangreffrath commented Jul 21, 2023

I am even considering to remove the 800x600 resolution support. It's an odd resolution (neither an integer multiple of 320x200 nor 320x240) and strictly had no place in a game of this time. Also, it requires too many exceptions in the code.

@malespiaut
Copy link
Contributor Author

I've never been a fan of higher resolutions for ROTT. So I'm not the one who's going to complain about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants