Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

readme js file #31

Closed
bnomei opened this issue Jan 7, 2018 · 3 comments
Closed

readme js file #31

bnomei opened this issue Jan 7, 2018 · 3 comments
Assignees
Milestone

Comments

@bnomei
Copy link

bnomei commented Jan 7, 2018

about 2.3 template setup of readme... should be minified file, right? its currently not.

<?= js('assets/plugins/imageset/js/dist/imageset.min.js') ?>
@fabianmichael
Copy link
Owner

@bnomei I added the uncrompressed file with dev environments in mind. Do you think, the minified version would make more sense? I guessed that most devs would include it in their build process anyway to have a single JS payload for production …

@bnomei
Copy link
Author

bnomei commented Feb 7, 2018

i did add the minified script to my loadjs chain so i can use whatever version your plugin provides – keeping plugin code separated from website code. no webpack merge etc.
you could add a note here that a minified version is available as well.

@fabianmichael
Copy link
Owner

Replaced with minified file in cb36c2c.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants