Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update prettier #205

Merged
merged 2 commits into from
Feb 19, 2024
Merged

update prettier #205

merged 2 commits into from
Feb 19, 2024

Conversation

nikravi
Copy link
Contributor

@nikravi nikravi commented Nov 2, 2023

This PR fixes the tailwind prettier plugin if it's used on the target repository,

#200

@Karnak19
Copy link
Contributor

any news on this ?

@fabien0102
Copy link
Owner

The lock file is not up-to-date…

@nikravi
Copy link
Contributor Author

nikravi commented Nov 28, 2023

@fabien0102 @Karnak19 updated the PR, build and npm ci is ok now. Thank you

@owonwo
Copy link

owonwo commented Jan 23, 2024

Hi @fabien0102 when do you plan on publishing this update?

@weedgrease
Copy link

this is still an issue for users using prettier@^3.x.x in their projects - can we get some eyes on this @fabien0102?

it also seems strange to me that this package's prettier version has any impact on being able to run the cli anywhere considering prettier is a dev dependency

Copy link
Owner

@fabien0102 fabien0102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, sorry for the very long review time…

@fabien0102 fabien0102 merged commit c8152b9 into fabien0102:main Feb 19, 2024
@github-actions github-actions bot mentioned this pull request Feb 19, 2024
@Karnak19
Copy link
Contributor

Hello, for some reason the cli package still depends on prettier@2.8.8 on my side

# extracted from my pnpm-lock
 /@openapi-codegen/cli@2.0.0(@types/react@18.2.66)(react-dom@18.2.0)(react@18.2.0):
    resolution: {integrity: sha512-LPQPZ+zj+ExyLFsEhUL8T2a4bbq28Ftqu9vZEGgAg+s8fyH7HzImvwNudaZivZ3S8uyl+7/RhPFJjZ7nPzLAaQ==}
    hasBin: true
    dependencies:
      '@apollo/client': 3.9.7(@types/react@18.2.66)(graphql@15.8.0)(react-dom@18.2.0)(react@18.2.0)
      '@swc/core': 1.4.8
      case: 1.6.3
      chalk: 5.3.0
      cli-highlight: 2.1.11
      clipanion: 3.2.1(typanion@3.14.0)
      fs-extra: 10.1.0
      got: 12.6.1
      got-fetch: 5.1.8(got@12.6.1)
      graphql: 15.8.0
      ink: 3.2.0(@types/react@18.2.66)(react@18.2.0)
      js-yaml: 4.1.0
      openapi3-ts: 2.0.2
      prettier: 2.8.8
      rxjs: 7.8.1
      slash: 4.0.0
      swagger2openapi: 7.0.8
      tslib: 2.6.2
      typanion: 3.14.0
      typescript: 4.8.2
    transitivePeerDependencies:
      - '@swc/helpers'
      - '@types/react'
      - bufferutil
      - encoding
      - graphql-ws
      - react
      - react-dom
      - subscriptions-transport-ws
      - utf-8-validate
    dev: true

npmgraph also shows it:
https://npmgraph.js.org/?q=@openapi-codegen/cli#select=exact%3Aprettier%402.8.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants