Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add null handling for @default tag #190

Merged

Conversation

tvillaren
Copy link
Collaborator

@tvillaren tvillaren commented Dec 5, 2023

Why

Implementing a solution to #188
This adds nullable to the modifiers when the property if the @default is null

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c0835b) 97.39% compared to head (d543af7) 97.40%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
+ Coverage   97.39%   97.40%   +0.01%     
==========================================
  Files          14       14              
  Lines         729      733       +4     
  Branches      301      304       +3     
==========================================
+ Hits          710      714       +4     
  Misses         19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@schiller-manuel schiller-manuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schiller-manuel schiller-manuel merged commit 6034727 into fabien0102:main Dec 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants