Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing check for show_inlines_as_tabs in template #390

Open
amuzhdaba opened this issue May 17, 2024 · 1 comment
Open

missing check for show_inlines_as_tabs in template #390

amuzhdaba opened this issue May 17, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@amuzhdaba
Copy link

amuzhdaba commented May 17, 2024

There is missing check for the show_inlines_as_tabs condition in the change_form.html (lines 66-73)
So even if I have this feature turned off it populates tabcontent blocks with inlines formsets.
At the same time corresponding condition check for the tablinks is not missing so you'll never see that hidden tabcontent blocks were populated.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@amuzhdaba amuzhdaba added the bug Something isn't working label May 17, 2024
@fabiocaccamo
Copy link
Owner

@amuzhdaba thank you for reporting this, this feature is hard to maintain because writing tests for it is a bit complicated (#301).

Do you want to submit a PR for fixing this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants