Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do we have 2 versions of jscolor ? #121

Closed
baseplate-admin opened this issue Apr 9, 2023 · 3 comments
Closed

Why do we have 2 versions of jscolor ? #121

baseplate-admin opened this issue Apr 9, 2023 · 3 comments
Assignees
Labels
question Further information is requested

Comments

@baseplate-admin
Copy link

Hi,

It seems that you are bundling 2 versions of jscolor.

if settings.DEBUG:
js = [
"colorfield/jscolor/jscolor.js",
"colorfield/colorfield.js",
]
else:
js = [
"colorfield/jscolor/jscolor.min.js",
"colorfield/colorfield.js",
]

Is there any particular reason for this?

@fabiocaccamo
Copy link
Owner

@baseplate-admin if DEBUG is True, the non minified jscolor version is used for simplifying debugging.

@baseplate-admin
Copy link
Author

if DEBUG is True, the non minified jscolor version is used for simplifying debugging.

Does minified JS change debugging that much?

Almost all the 1st/3rd party django js are using the minified codes

@fabiocaccamo
Copy link
Owner

Frankly I don'remember very well... btw having both files in the dist is not a big problem.

@fabiocaccamo fabiocaccamo self-assigned this Apr 17, 2023
@fabiocaccamo fabiocaccamo added the question Further information is requested label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants