Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django-fast-treenode #130

Closed
jacobjove opened this issue Nov 27, 2023 · 5 comments
Closed

django-fast-treenode #130

jacobjove opened this issue Nov 27, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@jacobjove
Copy link

jacobjove commented Nov 27, 2023

@fabiocaccamo , have you seen django-fast-treenode ?

I suggested that perhaps the changes in django-fast-treenode should be contributed to this package rather than maintained separately. What do you think?

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@jacobjove jacobjove added the enhancement New feature or request label Nov 27, 2023
@fabiocaccamo
Copy link
Owner

@iacobfred I totally agree. @TimurKady sent me the improved version long time ago, but I had not the time to check and compare it, because he sent me a whole refactored package instead of a PR with incremental changes.

So... if you want/have the time to work on a PR I will be glad to review and eventually merge it.

@TimurKady
Copy link

Hey folks, I'll genuinely be happy to wrap up my project! From the beginning, I suggested not creating separate entities and instead combining improvements. Furthermore, I'm more than willing to just jump in and assist.

Fabio, on my end, I've done everything within my capacity. As they say, the ball is in your court!

@jacobjove
Copy link
Author

jacobjove commented Dec 13, 2023

Hi @TimurKady , it's good to hear you're willing to jump in and wrap up your project.

As @fabiocaccamo pointed out, what we have currently is a whole refactored project (django-fast-treenode) rather than a PR. To wrap this up, we need to open a PR instead of sending Fabio a whole refactored package. If there is no PR, then we haven't yet done everything within our capacity and the ball is not yet in Fabio's court.

I think the steps to wrap this up are as follows:

  1. Make a new fork of django-treenode
  2. Make incremental changes (based on the changes you've already made in django-fast-treenode)
  3. Open a PR; get those changes merged into django-treenode
  4. Repeat 2–3 until django-treenode has all of your improvements from django-fast-treenode
  5. Archive django-fast-treenode

@fabiocaccamo
Copy link
Owner

@iacobfred @TimurKady I close this issue since I don't think that anyone is working on a PR.

@fabiocaccamo fabiocaccamo closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2024
@TimurKady
Copy link

Fabio, sorry, I'm currently busy with a large complex project. I can't maintain a PR.
You are free to use my code. Once you transfer it, I'll just delete my repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants