-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
django-fast-treenode #130
Comments
@iacobfred I totally agree. @TimurKady sent me the improved version long time ago, but I had not the time to check and compare it, because he sent me a whole refactored package instead of a PR with incremental changes. So... if you want/have the time to work on a PR I will be glad to review and eventually merge it. |
Hey folks, I'll genuinely be happy to wrap up my project! From the beginning, I suggested not creating separate entities and instead combining improvements. Furthermore, I'm more than willing to just jump in and assist. Fabio, on my end, I've done everything within my capacity. As they say, the ball is in your court! |
Hi @TimurKady , it's good to hear you're willing to jump in and wrap up your project. As @fabiocaccamo pointed out, what we have currently is a whole refactored project (django-fast-treenode) rather than a PR. To wrap this up, we need to open a PR instead of sending Fabio a whole refactored package. If there is no PR, then we haven't yet done everything within our capacity and the ball is not yet in Fabio's court. I think the steps to wrap this up are as follows:
|
@iacobfred @TimurKady I close this issue since I don't think that anyone is working on a PR. |
Fabio, sorry, I'm currently busy with a large complex project. I can't maintain a PR. |
@fabiocaccamo , have you seen django-fast-treenode ?
I suggested that perhaps the changes in django-fast-treenode should be contributed to this package rather than maintained separately. What do you think?
Upvote & Fund
The text was updated successfully, but these errors were encountered: