Wildcard support for renaming

[milhauzindahauz]

Desired functionality as following:

d = {
"a": [
  {
    "x": 1,
    "y": 1,
  },
  {
    "x": 2,
    "y": 2,
  },
  ]
}
b = benedict(d)
b.rename("a[*].x", "a[*].m")

[milhauzindahauz]

Hi @fabiocaccamo,

I want to use the module in my workflow. The benedict class has a lot of features but wildcard support for moving/renaming is missing. I checked the docs and usage of wildcard is possible in match method. So I made it working in #114.

I am not sure if I covered all use cases in tests. And I am not sure if this functionality is even desired.

Cheers.

[fabiocaccamo]

@milhauzindahauz thank you for the enhancement proposal and the PR. I will review the PR as soon as possible.

[milhauzindahauz]

@fabiocaccamo
what behaiviour should be expected with keypath = "a[*]"?

[fabiocaccamo]

@milhauzindahauz could you be more specific about the context?

[milhauzindahauz]

@fabiocaccamo check this out

d = {
    "a": [
        {"x": 1, "y": 1},
        {"x": 2, "y": 2},
    ],
    "x": [
        {"a": 10, "b": 10},
        {"a": 11, "b": 11},
    ],
}
b = benedict(d)
b.get("a[1]")

# should it be 
b.get("a") == b.get("a[*]")
# or
try:
    b.get("a[*]")
except KeypathError:
    pass

[fabiocaccamo]

@milhauzindahauz it should be b.get("a") == b.get("a[*]"), no doubts.

[fabiocaccamo]

@milhauzindahauz any update? I would like to publish a new release in the next days and it would be great having also this feature released.

[milhauzindahauz]

@fabiocaccamo I have had a little time for this for last week. There are few points from the last review I need to solve. I am not sure if I made to the release.

[fabiocaccamo]

@milhauzindahauz no problem, the release can wait.
Thank you very much for the quick feedback.