-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with consumer projects which already imported Quartz #42
Comments
Hi @rwellman-ats, Please can you elaborate which&where you've duplicated? |
Sure. I took the following approach to integrate - maybe not the best solution but I was in a hurry :)
[Note A] I might suggest renaming this property to 'quartz-manager.enabled' or 'quartz-manager.quartz.enabled', etc. I just think the semi-generic name you currently use might have a lot of potential for name conflict when integrating into existing codebase(s). In summary, I probably suggest renaming all your application properties to begin with 'quartz-manager'. [Note B] You will also notice that I renamed a couple of the beans to include "QuartzManager". This is because I needed to resolve the differences between your API beans and my existing beans since there are now two beans of the same type and Spring cannot tell them apart during startup. Then I had to tell my existing config to use my existing beans by using the
|
Put it in the roadmap! The possibility to use quartz-manager in a project already imported Quartz. In the meanwhile, what if you disable the dependency of Quartz in your project and let |
I'm only trying this as an experiment to help with the what-if question. I am suggesting that this NOT be the method you expect people to take to use this project. So before you read my notes below, let me offer my two cents on how I would expect this to work when it's finished:
|
So I tried this with mixed success:
|
Hey man, that was meant to be a temporary workaround. Nevermind, actually I put your proposal in the roadmap. |
Hi @rwellman-ats , |
I report the following quote from the issue #41 raised by @rwellman-ats:
The text was updated successfully, but these errors were encountered: