glob matching improvements

[sharbov]

Hey,

We've been using fabio for a while now, and we recently started using the glob matcher.

The problem we've encountered was that once we switched the matching strategy it affected all the endpoints matching, in addition to that the glob matcher does not match the '/' signs. these two issues forced us to add many new tags to existing services in order to try and cover all of the possibilities of each endpoint

e.g

urlprefix-/service/foo/*
urlprefix-/service/foo/*/*
urlprefix-/service/foo/*/*/* ...

This is clearly not the preferred solution, I would like to suggest three ways to go about this issue:

• Add a per tag matching strategy (e.g urlglob-/service/foo/*).
• Add support for double '*' wild card, which will match '/' signs.
• Add a new matcher - a regex matcher.

If any of these ideas sounds reasonable to you, I would be happy to open a pull request for them.

relates to #341

Thanks,
Shay

[magiconair]

Hey Shay, I think extending the current glob matcher with `**` logic would be a good idea and it should be backwards compatible. Adding a regex matcher in addition to that would help, too. Bonus points for adding a route option to select this per route instead of using a global flag. PR is very welcome. Frank — Frank Schröder

…

On 26. Feb 2018, at 17:05, Shay Arbov ***@***.***> wrote: Hey, We've been using fabio for a while now, and we recently started using the glob matcher. The problem we've encountered was that once we switched the matching strategy it affected all the endpoints matching, in addition to that the glob matcher does not match the '/' signs. these two issues forced us to add many new tags to existing services in order to try and cover all of the possibilities of each endpoint e.g urlprefix-/service/foo/* urlprefix-/service/foo/*/* urlprefix-/service/foo/*/*/* ... This is clearly not the preferred solution, I would like to suggest three ways to go about this issue: Add a per tag matching strategy (e.g urlglob-/service/foo/*). Add support for double '*' wild card, which will match '/' signs. Add a new matcher - a regex matcher. If any of these ideas sounds reasonable to you, I would be happy to open a pull request for them. Thanks, Shay — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[eliasbrange]

Just stumbled upon this and installed 1.5.9 to fix the problem. However, now it seems to work with both * and **. E.g. /some/path/here is matched by both /some/** and /some/*. What are the preferred way?