New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom interactive prompts #1021
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changes to make it nicer
+1 |
Was leery about this originally, but the changes this makes to core (aka the bits in |
bitprophet
added a commit
that referenced
this pull request
Dec 17, 2013
bitprophet
added a commit
that referenced
this pull request
Dec 17, 2013
bitprophet
added a commit
that referenced
this pull request
Dec 17, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improves and fixes #741. might fix #177 (not sure though) and probably also helps with #7 (also I don't know if that one is really fully solvable).
There's an implementation difference. The
env
variable is not namedprompt_responses
anymore butprompts
, because I think it's shorter and a better fit.For the future we could think about two things:
run()
doesn't contain the complete text. That's not extremely bad, but we could improve this by counting bytes (and just not trying to check for a new prompt if the number of bytes doesn't change). But I don't really know what side effects that would have, since it's also possible to just answer prompts manually (and use the backward button).And also I would like to see tox in fabric. It makes testing (especially the setting up part) way easier (if you haven't heard of it: it eases testing against multiple python versions).
Now you can do something like:
Not that this example makes sense, but it shows the use case well: interactive prompts.
When could we expect a release containing that code?