New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working py3 port #1378

Closed
mathiasertl opened this Issue Sep 13, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@mathiasertl

mathiasertl commented Sep 13, 2015

I have a working Python 3 port of fabric here. Working, as in: all tests work. The code works with Python3.4 and Python2.7 (that's all currently supported python versions, mind you). The diff is not even that great, this includes all changes in the tests as well:

git diff upstream/master --stat
 ...
 29 files changed, 228 insertions(+), 177 deletions(-)

Turns out, you can have a version with the basic functionality working (e.g. run()...) with very few code changes: if you sacrifice Python 2.5 comparability of course.

I'm unsure how I should proceed: If you agree fabric can drop Python 2.5 support, I could start making smaller pull requests right away. If you absolutely need 2.5 support, I could maintain my own fork that py3-people can use.

@bitprophet

This comment has been minimized.

Show comment
Hide comment
@bitprophet

bitprophet Sep 13, 2015

Member

Python 3 support is coming in 2.x, with an alpha due out by end of month. Thanks, but sorry :) (Also, no, dropping 2.5 support in 1.x is not feasible, though we are - as you've found - having to drop it in 2.x, in part due to the 2+3 support headaches.)

Member

bitprophet commented Sep 13, 2015

Python 3 support is coming in 2.x, with an alpha due out by end of month. Thanks, but sorry :) (Also, no, dropping 2.5 support in 1.x is not feasible, though we are - as you've found - having to drop it in 2.x, in part due to the 2+3 support headaches.)

@bitprophet bitprophet closed this Sep 13, 2015

@rodrigc

This comment has been minimized.

Show comment
Hide comment
@rodrigc

rodrigc Oct 1, 2015

@mathiasertl: thanks for working on this. Even though @bitprophet is not accepting your patches, please keep your branch open. It is useful for people in a bind who need to use Python 3, and also want to use Fabric

rodrigc commented Oct 1, 2015

@mathiasertl: thanks for working on this. Even though @bitprophet is not accepting your patches, please keep your branch open. It is useful for people in a bind who need to use Python 3, and also want to use Fabric

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.