Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During a failure, the ran_jobs result dictionary may not be fully initalized #742

Closed
dekimsey opened this issue Sep 27, 2012 · 1 comment

Comments

@dekimsey
Copy link

$ fab -v
Fabric 1.4.3
ssh (library) 1.7.14

In my fabfile, one of the commands early on may fail. In normal, serial mode I get typical failure output, in parallel mode however, the program aborts with a KeyError exception. I do not know why the 'results' key in the ran_jobs dictionary may not always be defined. But that appears to be a problem for the following code in fabric/tasks.py's execute method.

              ran_jobs = jobs.run()
              for name, d in ran_jobs.iteritems():
                  import pprint
                  pprint.pprint(d)

                  if d['exit_code'] != 0:
# Problem here, results may not be defined.
                      if isinstance(d['results'], BaseException):
                          error(err, exception=d['results'])
                      else:
                          error(err)
                  results[name] = d['results']
@bitprophet
Copy link
Member

This looks like a dupe of #693, which is fixed & will be out in 1.5 and (I think) 1.4.4. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants