New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Users to Namespaces, when inappropriately used #188

Open

kishansagathiya opened this issue Mar 12, 2018 · 1 comment

Labels

kind/task priority/minor

Member

kishansagathiya commented Mar 12, 2018 •

edited by hferentschik

Loading

https://github.com/fabric8-services/fabric8-jenkins-proxy/blob/master/internal/storage/db_store.go#L44
GetUsers() gets namespaces. It should rather be GetNamespaces().

https://github.com/fabric8-services/fabric8-jenkins-proxy/blob/master/internal/storage/db_store.go#L69
GetStatisticsUser(ns) to GetNamespaceStatistics(ns)

Member Author

kishansagathiya commented Mar 12, 2018

https://github.com/fabric8-services/fabric8-jenkins-proxy/blob/master/internal/util/multi_error.go#L16
Collect instead of Append also seems to be a misnomer. I think the same thing is done the idler as well.

hferentschik added kind/task priority/minor labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment