Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Create Error Infrastructure #100

Closed
tsmaeder opened this issue Aug 10, 2016 · 5 comments
Closed

Create Error Infrastructure #100

tsmaeder opened this issue Aug 10, 2016 · 5 comments
Milestone

Comments

@tsmaeder
Copy link
Contributor

Coming out of discussions on #80, we should define common policies and infrastucture for reporting errors in ALM. Some features I would envision:

  • Remember the context.Context at the time of creation
  • Have a stack trace
  • allow for nesting of errors (thus allowing for reconstruction of call stack and context chain)
@tsmaeder
Copy link
Contributor Author

Oh and yeah: 100th post!

@aslakknutsen
Copy link
Contributor

damn it!! I've been doing Issue cleanup work for seemingly no good reason...

@tsmaeder
Copy link
Contributor Author

I read somewhere that one should still return "error" instead of more elaborate types, not sure why, though. Are interfaces assignement compatible in golang? Need to test.

@sbose78
Copy link
Member

sbose78 commented Aug 12, 2016

Hi,
Has this been taken care of as part of https://github.com/almighty/almighty-core/pull/80/files , models/error.go Or are there more changes coming in ?

@tsmaeder
Copy link
Contributor Author

No, the errors in that PR are an ad-hoc creation which lead to discussions about what requirements we have for error reporting.

@joshuawilson joshuawilson modified the milestone: Backlog Jul 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants