fix(lib): removes ngx-compat and feedback module

package.json

@@ -45,7 +45,6 @@
     "ngx-login-client": "^2.3.1",
     "ngx-modal": "^0.0.29",
     "rxjs": "^6.0.0",
-    "rxjs-compat": "^6.3.0",
     "zone.js": "~0.8.26"
   },
   "devDependencies": {

projects/fabric8-stack-analysis-ui/src/lib/stack/card-details/report-information/report-information.component.spec.ts

@@ -15,7 +15,6 @@ import { AddWorkFlowService } from '../../stack-details/add-work-flow.service';
 
 import { NoDataComponent } from './no-data/no-data.component';
 
-import { ReportInformationModule } from './report-information.module';
 import { ToastNotificationModule } from '../../toast-notification/toast-notification.module';
 
 const mockAddWorkFlowService = {

projects/fabric8-stack-analysis-ui/src/lib/stack/pipeline-insights/pipeline-insights.service.ts

@@ -1,7 +1,7 @@
 import { Injectable } from '@angular/core';
 import { HttpErrorResponse, HttpHeaders, HttpClient, HttpResponse } from '@angular/common/http';
 import { AuthenticationService } from 'ngx-login-client';
-import { Observable } from 'rxjs';
+import { Observable, throwError } from 'rxjs';
 import { catchError, map } from 'rxjs/operators';
 
 import { StackReportModel } from '../models/stack-report.model';
@@ -49,7 +49,7 @@ export class PipelineInsightsService {
         statusText: error.statusText
       };
     }
-    return Observable.throw(body);
+    return throwError(body);
   }
 
 }

projects/fabric8-stack-analysis-ui/src/lib/stack/stack-analyses.service.ts

@@ -1,7 +1,7 @@
 import { Injectable } from '@angular/core';
 import { HttpErrorResponse, HttpHeaders, HttpClient, HttpResponse } from '@angular/common/http';
 import { AuthenticationService } from 'ngx-login-client';
-import { Observable } from 'rxjs';
+import { Observable, throwError } from 'rxjs';
 import { catchError, map } from 'rxjs/operators';
 
 import { StackReportModel } from './models/stack-report.model';
@@ -87,7 +87,7 @@ export class StackAnalysesService {
         statusText: error.statusText
       };
     }
-    return Observable.throw(body);
+    return throwError(body);
   }
 
 }

projects/fabric8-stack-analysis-ui/src/lib/stack/stack-details/add-work-flow.service.ts

@@ -2,9 +2,7 @@ import { Injectable, Inject } from '@angular/core';
 import { HttpErrorResponse, HttpHeaders, HttpClient, HttpResponse } from '@angular/common/http';
 import { AuthenticationService } from 'ngx-login-client';
 import { WIT_API_URL, Contexts } from 'ngx-fabric8-wit';
-import { Observable } from 'rxjs';
-// import 'rxjs/add/operator/catch';
-// import 'rxjs/operators/map';
+import { Observable, throwError } from 'rxjs';
 import { catchError, map } from 'rxjs/operators';
 
 @Injectable()
@@ -111,7 +109,7 @@ export class AddWorkFlowService {
       const err = body.error || JSON.stringify(body);
       errMsg = `${error.status} - ${error.statusText || ''} ${err}`;
     }
-    return Observable.throw(errMsg);
+    return throwError(errMsg);
   }
 
 }

projects/fabric8-stack-analysis-ui/src/lib/stack/stack-details/stack-details-component.spec.ts

@@ -10,9 +10,6 @@ import { TabsModule, AccordionModule } from 'ngx-bootstrap';
 
 
 /** New UX */
-// import {StackLevelModule} from '../stack-level/stack-level.module';
-// import {ComponentLevelModule} from '../component-level/component-level.module';
-import { FeedbackModule } from '../feedback/feedback.module';
 import { PipelineInsightsModule } from '../pipeline-insights/pipeline-insights.module';
 
 import { Broadcaster } from 'ngx-base';
@@ -50,9 +47,6 @@ describe ('StackDetailsComponent', () => {
                 HttpClientModule,
                 FormsModule,
                 ModalModule,
-                // StackLevelModule,
-                // ComponentLevelModule,
-                FeedbackModule,
                 PipelineInsightsModule,
                 AccordionModule.forRoot(),
                 TabsModule.forRoot(),

projects/fabric8-stack-analysis-ui/src/lib/stack/stack-details/stack-details.module.ts

@@ -10,9 +10,6 @@ import { GlobalConstants } from '../constants/constants.service';
 import { StackDetailsComponent } from './stack-details.component';
 
 /** New UX */
-// import {StackLevelModule} from '../stack-level/stack-level.module';
-// import {ComponentLevelModule} from '../component-level/component-level.module';
-import { FeedbackModule } from '../feedback/feedback.module';
 import { PipelineInsightsModule } from '../pipeline-insights/pipeline-insights.module';
 /** New UX */
 

projects/fabric8-stack-analysis-ui/src/lib/stack/utils/component-feedback/component-feedback.component.ts

@@ -17,7 +17,6 @@ import { ComponentFeedbackService } from './component-feedback.service';
 @Component({
     selector: 'component-feedback',
     styleUrls: ['./component-feedback.component.less'],
-    // providers: [ComponentFeedbackService],
     templateUrl: './component-feedback.component.html'
 })
 export class ComponentFeedbackComponent implements OnChanges {

projects/fabric8-stack-analysis-ui/src/lib/stack/utils/component-feedback/component-feedback.service.ts

@@ -1,7 +1,7 @@
 import { Injectable } from '@angular/core';
 import { HttpErrorResponse, HttpHeaders, HttpClient, HttpResponse } from '@angular/common/http';
 import { AuthenticationService } from 'ngx-login-client';
-import { Observable } from 'rxjs';
+import { Observable, throwError } from 'rxjs';
 import { catchError, map } from 'rxjs/operators';
 
 import { MComponentFeedback } from '../../models/ui.model';
@@ -49,7 +49,7 @@ export class ComponentFeedbackService {
         statusText: error.statusText
       };
     }
-    return Observable.throw(body);
+    return throwError(body);
   }
 
 }