This repository has been archived by the owner on May 7, 2021. It is now read-only.
feat(logout): new logout implementation using /logout/v2 API #3513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianvogt
suggested changes
Feb 1, 2019
| @@ -13,6 +14,10 @@ export class JsonApiError extends Error implements IJsonApiError { | |||
| } | |||
| } | |||
|
|
|||
| export async function fetch(url: string): Promise<MetaObject> { | |||
There was a problem hiding this comment.
Change this to fetch<T>(url: string): Promise<T> to force clients of this API to provide a proper type.
| return function(dispatch) { | ||
| return async function(dispatch) { | ||
| const logoutUrl = getLogoutUrl(window.location.origin); | ||
| const result: { [key: string]: any } = await fetch(logoutUrl); |
There was a problem hiding this comment.
Add a proper interface for the expected response instead of a key / value pair of strings.
|
The E2E smoke test with feature level set to 'beta' failed. Please review the job results and re-run the job by commenting [e2e-test-beta] if necessary. |
|
The E2E smoke test with feature level set to 'released' failed. Please review the job results and re-run the job by commenting [e2e-test-released] if necessary. |
christianvogt
approved these changes
Feb 1, 2019
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
karthikjeeyar
pushed a commit
to karthikjeeyar/fabric8-ui
that referenced
this pull request
Feb 6, 2019
…-ui#3513) * feat(logout): new logout implementation using /logout/v2 API * fix(types): add better type checking for fetch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes openshiftio/openshift.io#4742
/logout/v2endpoint.logout/v2with redirect param. the response then sends aredirect_locationand we redirect to that url.jsonapi.clienttohttp.clientand added simple fetch method for axios get.