Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log messages getting cut off in the build #163

Merged
merged 2 commits into from May 15, 2015
Merged

Fix log messages getting cut off in the build #163

merged 2 commits into from May 15, 2015

Conversation

ghost
Copy link

@ghost ghost commented May 12, 2015

Hi,

I was getting log messages being cut off in the build:

[ERROR] DOCKER> Invalid log format for '201' (expected: " ")

I switched this method:

https://docs.oracle.com/javase/7/docs/api/java/io/InputStream.html#read(byte[],%20int,%20int)

"An attempt is made to read as many as len bytes, but a smaller number may be read. The number of bytes actually read is returned as an integer."

for this method:

https://commons.apache.org/proper/commons-io/apidocs/org/apache/commons/io/IOUtils.html#read(java.io.InputStream, byte[], int, int)

"This implementation guarantees that it will read as many bytes as possible before giving up"

Cheers,
Dan

Dan Keast added 2 commits May 12, 2015 08:52
no guarantee that it was reached.

Signed-off-by: Dan Keast <dan@kea.st>
Signed-off-by: Dan Keast <dan@kea.st>
@rhuss
Copy link
Collaborator

rhuss commented May 13, 2015

Thanks a lot ! 'will be in the next release.

@rhuss rhuss added the fixed label May 13, 2015
@ghost
Copy link
Author

ghost commented May 13, 2015

Fantastic! It's a really great project, we're using pretty much all of it's
features in my project now.
On 13 May 2015 16:58, "Roland Huß" notifications@github.com wrote:

Thanks a lot ! 'will be in the next release.


Reply to this email directly or view it on GitHub
https://github.com/rhuss/docker-maven-plugin/pull/163#issuecomment-101724191
.

@rhuss rhuss added this to the 0.11.4 milestone May 13, 2015
@rhuss rhuss self-assigned this May 13, 2015
@rhuss
Copy link
Collaborator

rhuss commented May 13, 2015

Thanks ;-) And thanks for the PR ...

@rhuss rhuss added applied and removed fixed labels May 13, 2015
@rhuss rhuss merged commit f89f19d into fabric8io:master May 15, 2015
leusonmario pushed a commit to leusonmario/docker-maven-plugin that referenced this pull request Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant