Add filtering

[rhuss]

Tune this with parameter <filter>.

[pepperbot]

Replace the synchronized class "StringBuffer" by an unsynchronized one such as "StringBuilder".

[pepperbot]

Return an empty array instead of null.

[codecov]

Codecov Report

Merging #777 into master will decrease coverage by 0.04%.
The diff coverage is 52.87%.

@@             Coverage Diff              @@
##             master     #777      +/-   ##
============================================
- Coverage     47.46%   47.41%   -0.05%     
- Complexity     1054     1063       +9     
============================================
  Files           134      134              
  Lines          6835     6909      +74     
  Branches        888      904      +16     
============================================
+ Hits           3244     3276      +32     
- Misses         3316     3352      +36     
- Partials        275      281       +6

Impacted Files	Coverage Δ	Complexity Δ
.../io/fabric8/maven/docker/service/BuildService.java	30.07% <0%> (-0.46%)	9 <0> (ø)
...8/maven/docker/assembly/DockerAssemblyManager.java	12.76% <0%> (-1.66%)	6 <0> (ø)
...config/handler/property/PropertyConfigHandler.java	90.3% <100%> (+0.04%)	40 <0> (ø)	⬇️
...aven/docker/config/handler/property/ConfigKey.java	100% <100%> (ø)	7 <0> (ø)	⬇️
...a/io/fabric8/maven/docker/util/DockerFileUtil.java	79.59% <80%> (+19.59%)	13 <13> (+11)	⬆️
...8/maven/docker/config/BuildImageConfiguration.java	81.64% <88.88%> (-0.18%)	45 <1> (ø)
...ain/java/io/fabric8/maven/docker/util/EnvUtil.java	58.51% <0%> (-4.45%)	37% <0%> (-2%)

[pepperbot]

SonarQube analysis reported 4 issues

• 2 major
• 2 minor

Watch the comments in this conversation to review them.

2 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

1. BuildImageConfiguration.java#L440: Remove this use of "command"; it is deprecated.
2. BuildImageConfiguration.java#L451: Remove this use of "command"; it is deprecated.

[rhuss]

self-[merge], don't wanna bother you with this feature. I will take the consequences for this :)

[rhuss]

@realmfoo The logic wrt with Dockerfiles is explained in the manual. By default, if dockerFile is given, and its a relative path, its looked up relatively to src/main/docker.

The reason why you can specify the Dockerfile name is, that you might have a single directory with multiple, slightly differing Dockerfile but the same files e.g. to COPY. So you can use different dockerFile configs in your image to reuse those files.

[realmfoo]

I have read manual before adding a comment. And I've debugged plugin to find out why it's not working for me. If my file name is Dockerfile, then it works fine. But when I rename it to another name plugin creates file with Dockerfile as a name and upload it to docker engine. Then it sends command to build image but uses original file name. I've made change locally and it worked as expected. I'll create a working example tomorrow.

…

On Tue, May 23, 2017 at 3:23 PM, Roland Huß ***@***.***> wrote: @realmfoo <https://github.com/realmfoo> The logic wrt with Dockerfiles is explained in the manual <https://dmp.fabric8.io/#docker:build>. By default, if dockerFile is given, and its a relative path, its looked up relatively to src/main/docker. The reason why you can specify the Dockerfile *name* is, that you might have a single directory with multiple, slightly differing Dockerfile but the same files e.g. to COPY. So you can use different dockerFile configs in your image to reuse those files. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#777 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAr7Qk-F5JVGku-qz72eCGKAu32gLXKWks5r8s_MgaJpZM4Nce69> .

-- С уважением, Константин