This repository has been archived by the owner on May 7, 2021. It is now read-only.
WIP Use /api/users endpoint instead of /api/identities for fetching list of users #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeykazakov
force-pushed
the
issue-672
branch
from
d483409
to
6d96d93
Compare
sanbornsen
suggested changes
Feb 8, 2017
| @@ -15,7 +15,7 @@ import { User } from '../models/user'; | |||
| export class UserService { | |||
| private headers = new Headers({'Content-Type': 'application/json'}); | |||
| private userUrl = process.env.API_URL + 'user'; // URL to web api | |||
| private identitiesUrl = process.env.API_URL + 'identities'; // URL to web api | |||
| private usersUrl = process.env.API_URL + 'users'; // URL to web api | |||
There was a problem hiding this comment.
Does this end point exist?
There was a problem hiding this comment.
Not yet. And as I said in the description (see above ^) please do NOT merge until fabric8-services/fabric8-wit#692 is merged ;)
There was a problem hiding this comment.
Yeah, sorry I missed that. My bad.
sanbornsen
approved these changes
Feb 8, 2017
debloper
reviewed
Feb 9, 2017
| @@ -30,7 +30,7 @@ export class UserService { | |||
| } else { | |||
| logger.log('UserService running in production mode.'); | |||
| } | |||
| logger.log('UserService using user url ' + this.userUrl + ' identity url ' + this.identitiesUrl); | |||
| logger.log('UserService using user url ' + this.userUrl + ' users url ' + this.usersUrl); | |||
There was a problem hiding this comment.
Do we need the logger at this point?
There was a problem hiding this comment.
I don't know but I didn't remove the original one. Just updated it accordingly.
alexeykazakov
force-pushed
the
issue-672
branch
from
6d96d93
to
0f43de9
Compare
|
fabric8-services/fabric8-wit#692 has been merged. This one should be merged now too. |
|
[test] |
1 similar comment
|
[test] |
|
Another PR is raised with the same changes and fixed tests - #930 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes fabric8-services/fabric8-wit#672