Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

List spaces from backend in UI #62

Merged
merged 1 commit into from Jan 19, 2017
Merged

List spaces from backend in UI #62

merged 1 commit into from Jan 19, 2017

Conversation

VineetReynolds
Copy link
Contributor

@VineetReynolds VineetReynolds commented Jan 16, 2017

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fixes #66. Allows listing of spaces from the REST API backend.

  • What is the current behavior? (You can also link to an open issue here)

Lists spaces from DummyService.

  • What is the new behavior (if this is a feature change)?

Lists spaces from the backend API.

  • Other information:

Open questions to be addressed before merging:

  1. Should the spaces be listed using the infinite scroll view, instead of the current tabular view? The SpacesService in Initial version of SpaceService. #61 implements pagination, so this requires UI component changes.
  2. Please merge this after Initial version of SpaceService. #61, as this builds on functionality in that PR.

@VineetReynolds VineetReynolds mentioned this pull request Jan 16, 2017
@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@pmuir
Copy link
Contributor

pmuir commented Jan 16, 2017

I approved, but only the second commit, the first I commented in the other PR.

@pmuir
Copy link
Contributor

pmuir commented Jan 16, 2017

[test]

@joshuawilson
Copy link
Collaborator

[test]

@joshuawilson joshuawilson merged commit ff4a22c into fabric8-ui:master Jan 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SpacesComponent to list spaces fetched by SpacesService
4 participants