Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read index-pattern data from files rather than hardcoded constants #49

Closed
jcantrill opened this issue Oct 17, 2016 · 3 comments
Closed

Comments

@jcantrill
Copy link
Collaborator

as mentioned in #48

@richm richm changed the title Move operations fields to external file Read index-pattern data from files rather than hardcoded constants Oct 17, 2016
@richm
Copy link
Contributor

richm commented Oct 17, 2016

The kibana index-pattern data is a single line, several thousand byte JSON blob hardcoded into constant strings in the DocumentBuilder class. Instead, we should read this data from JSON or YAML files. viaq can generate the elasticsearch index templates as json or yaml files - it could also generate the corresponding kibana index-pattern data and other config data. ViaQ/elasticsearch-templates#17

@richm
Copy link
Contributor

richm commented Oct 18, 2016

Partially addressed by #51 - if using elasticsearch index templates, kibana index patterns are not needed

@jcantrill
Copy link
Collaborator Author

Closing as will be fixed by #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants