Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stateful: false doesn't fire object:modified #2362

Closed
snout-o opened this issue Jul 27, 2015 · 2 comments · Fixed by #2890
Closed

Stateful: false doesn't fire object:modified #2362

snout-o opened this issue Jul 27, 2015 · 2 comments · Fixed by #2890
Labels

Comments

@snout-o
Copy link

snout-o commented Jul 27, 2015

(cross posting from google groups)

Hi guys, quick question for what I suspect is a perfectly understood situation:

I've created a fiddle https://jsfiddle.net/sibbaldl/f6q3agtf/1/ that demonstrates a simple situation whereby, if a canvas is initialised with "stateful:false" the "object:modified" event won't fire when moving the red square around and releasing the mouse button. The event will fire if stateful:true.
It took me a while to realise the cause of this in my code, because even with stateful set to false other events such as scale,rotate,move will fire.

Just wanted to know if this is expected behaviour.

Cheers!

Lee

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@kangax
Copy link
Member

kangax commented Oct 11, 2015

Hm, I don't think this is expected or desired behavior, so marking as bug. Thanks for catching!

@kangax kangax added the bug label Oct 11, 2015
@asturur
Copy link
Member

asturur commented Apr 13, 2016

I checked stateful situation.
It looks like it has been left uncompleted.
stateproperties are lot, but the only check we have on "hasStateChanged" is on "finalizeCurrentTransform"
We can fire object:modified anyway there, but at this point statefull will become useless because it will collect stateproperties before every transform, but it will never check them.
Also stateproperties include lot of properties ( fill, stroke, opacity... ) and those do not have correlation with transforms.

check #2890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants