New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated rollup dependencies #8557
Conversation
Build Stats
|
"rollup": "^2.75.6", | ||
"rollup-plugin-size-snapshot": "^0.12.0", | ||
"rollup-plugin-terser": "^7.0.2", | ||
"rollup": "^3.9.0", | ||
"rollup-plugin-ts": "^3.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about the ts plugin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw you added and then removed it...
You must update typescript as well I believe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh I see that is the cause of the major fuck up in classes
Should i continue on this PR or move to more TS finishing? |
whatever you think |
I think i understood the code change issue.
without giving it a full value, either that gets removed from the traspiler, or it gets initialized to void. Initializing to void override whatever is on the prototype. Using I think the safe approach, while boring, is to add |
That will be boring and long, since it requires to change all the classes again, and temporary since we need to fix the default values anyway. So i shouldn't waste time on that but rather go straight to the default value issue |
On top of that i don't like our declarations are emitted right now. |
@@ -1,3 +1,2 @@ | |||
# Browsers that we support | |||
|
|||
chrome >= 58 | |||
chrome >= 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just trying around, not supposed to change this file
} | ||
export default fabric; | ||
|
||
export { fabric }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i m really not sure all this mess is worth for this change tho.
"@babel/plugin-transform-typescript": "^7.20.7", | ||
"@babel/preset-env": "^7.20.2", | ||
"@babel/preset-typescript": "^7.18.6", | ||
"@rollup/plugin-babel": "^6.0.3", | ||
"@rollup/plugin-json": "^6.0.0", | ||
"@rollup/plugin-terser": "^0.2.1", | ||
"@rollup/plugin-typescript": "^10.0.1", | ||
"@swc/cli": "^0.1.59", | ||
"@swc/core": "^1.3.24", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are not keeping all of those, searching for a simple subset
A different approach: |
Can you link me to the module script tag specs? i don't understand which feature you refer to. |
For later reference for me: |
Oh ok the MJS browser modules. I m also not ready to support it. If someone makes me a question i have to go and study. I want to do canvas and drawing not pioneer js stuff. The old string concatenation build was awesome now that i look back. |
Motivation
This update seems to have no side effects on the build
Just a reference branch to experiment with using exports
Description
Changes
Gist
In Action