Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: [Group Flip] Scaling Flip Group then Scaling Flip its child object, the child object behavior is wrong #9859

Open
7 tasks done
ritali4912 opened this issue May 6, 2024 · 4 comments
Assignees
Labels

Comments

@ritali4912
Copy link

ritali4912 commented May 6, 2024

CheckList

  • I agree to follow this project's Code of Conduct
  • I have read and followed the Contributing Guide
  • I have read and followed the Issue Tracker Guide
  • I have searched and referenced existing issues and discussions
  • I am filing a BUG report.
  • I have managed to reproduce the bug after upgrading to the latest version
  • I have created an accurate and minimal reproduction

Version

6.0.0-rc1

In What environments are you experiencing the problem?

Microsoft Edge

Node Version (if applicable)

None

Link To Reproduction

https://codesandbox.io/p/sandbox/fabric-vanillajs-sandbox-forked-qf599w

Steps To Reproduce

Actually I'm using the master in above reproduce link.

I want to verify the PR 9801, then I found a new issue.

  1. Scaling flip the Group first
  2. Scaling Flip one child object

The wrong behavior like below gif.

flip-group-child

Expected Behavior

The child object inside group can be scaling flip correctly no matter I flip the Group or not.

Actual Behavior

The original issue fixed by PR9801 is gone which is: Don't scaling flip the group, only scaling flip the child object. But it seems the fix is not complete.
Refer to below gif.

flip-group-child-2

Error Message & Stack Trace

No response

@asturur
Copy link
Member

asturur commented May 6, 2024

I m not sure i will be able to fix that, because i already tried and fix some other use cases of it.
The fact that the object will flip is something we can't do much about, is how the transformations are calculated and while you could argue that for a simple flip you can calculate when an object should be flipped, that become almost impossible when the transformations stack differently.

Can you please check how this use case was behaving before i merged the fix for your previous issue?
I need to understand if i broke something in case i have to consider reverting

@asturur asturur added the bug label May 6, 2024
@asturur asturur self-assigned this May 6, 2024
@ritali4912
Copy link
Author

ritali4912 commented May 6, 2024

@asturur I think you are not break anything.
Here is the reproduce on beta 20: https://jsfiddle.net/ritali4912/51afjotp/73/

The Use Cases are:

  1. Flip Child object inside Group only (not flip group)
    This is the one fixed by PR 9801, and the behavior is correct on master.

master behavior as below gif:

flip-group-case1-master

The behavior on beta 20 is wrong, refer to below gif.

flip-group-case1

  1. Flip Group -> Flip Child object
    This issue both on master and beta 20.

master behavior:
flip-group-child

The behavior on beta 20, refer to below gif:
flip-group-case2

The different between the beta20 and master you can see:

  1. On beta20, if I directly flip group then I can see the child object is:
    image

  2. On master, if I directly flip group then the child object is
    image

@ShaMan123
Copy link
Contributor

related #8743?

@asturur
Copy link
Member

asturur commented May 6, 2024

no i think #8743 has been fixed in the previous PR, a flipped object inside a group, this is slightly different and hopefully a different root cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants