Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClientPlayNetworking.registerGlobalReceiver handler getting called with null player #3602

Closed
henkelmax opened this issue Feb 18, 2024 · 2 comments · Fixed by #3603
Closed

ClientPlayNetworking.registerGlobalReceiver handler getting called with null player #3602

henkelmax opened this issue Feb 18, 2024 · 2 comments · Fixed by #3603
Assignees
@modmuss50
Labels
bug Something isn't working priority:high High priority PRs that need review and work now. Review these first.

Comments

@henkelmax
Copy link

When using ClientPlayNetworking.registerGlobalReceiver, the PlayPayloadHandler is getting called with a null player in the Context.
Here a screenshot from the debugger:
image

This happens in 24w07a with 0.96.2+1.20.5.

It seems to have been introduced in 24w03b with the networking changes.
@modmuss50 modmuss50 added bug Something isn't working priority:high High priority PRs that need review and work now. Review these first. labels Feb 18, 2024
@modmuss50 modmuss50 self-assigned this Feb 18, 2024
@modmuss50 modmuss50 linked a pull request Feb 18, 2024 that will close this issue
Fix ClientPlayNetworking.Contexnt.player() being null #3603
Merged
@modmuss50
Copy link
Member

Thanks a lot for trying out the 1.20.5 builds and finding this. I have created a PR with the fix here: #3603 I plan to release this (along with some other fixes) later today. 👍

@henkelmax
Copy link
Author

Thank you for the quick fix! Works perfectly in 0.96.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@modmuss50 modmuss50

Labels
bug Something isn't working priority:high High priority PRs that need review and work now. Review these first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ClientPlayNetworking.Contexnt.player() being null modmuss50/fabric
2 participants
@modmuss50 @henkelmax