Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few incorrect mappings in 1.14.4 #11

Closed
gamax92 opened this issue Oct 10, 2019 · 2 comments
Closed

A few incorrect mappings in 1.14.4 #11

gamax92 opened this issue Oct 10, 2019 · 2 comments

Comments

@gamax92
Copy link

gamax92 commented Oct 10, 2019

There are a few entries in the mappings for 1.14.4.tiny that have the intermediary name as the official name. I searched through the list of methods and their signatures to correct the first 7, but the last two entries have the same signature so unsure.

I have not taken a look through the other mappings so these issues might exist within multiple files.

METHOD  cvp$a   ()Lcvp; method_21055    method_21055    doConnect
Fixed (method_21055 -> e)
METHOD  cvp$b   ()Lcvp; method_21055    method_21055    doConnect
Fixed (method_21055 -> e)
METHOD  cvp$c   ()Lcvp; method_21055    method_21055    doConnect
Fixed (method_21055 -> e)
METHOD  cvp$d   ()Lcvp; method_21055    method_21055    doConnect
Fixed (method_21055 -> e)
METHOD  cwg     (ILcwa$a;ZZ)V   method_21108    method_21108    onSlotClick
Fixed (method_21108 -> a)
METHOD  cwg     (Ljava/lang/Object;)V   method_21395    method_21395    callback
Fixed (method_21395 -> a)
METHOD  cwu     (Ljava/lang/Object;)V   method_21395    method_21395    callback
Fixed (method_21395 -> a)
METHOD  cxh$d   ()V     method_21068    method_21068    tick
METHOD  cxh$d   ()V     method_21071    method_21071    abortTask
@liach
Copy link

liach commented Oct 10, 2019

These entries are fine as I see in https://raw.githubusercontent.com/FabricMC/intermediary/master/mappings/1.14.4.tiny

This is an issue related to yarn. Mind opening an issue there and close this issue?

@gamax92
Copy link
Author

gamax92 commented Oct 10, 2019

Oh my bad

@gamax92 gamax92 closed this as completed Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants